Issue 438 - Build on JDK 17 targeting Java 11 #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still need to update the lambda deployments and the docker images |
patchwork01
reviewed
Jan 5, 2023
...atus-store/src/test/java/sleeper/ingest/status/store/job/QueryIngestJobStatusByPeriodIT.java
Show resolved
Hide resolved
patchwork01
reviewed
Jan 5, 2023
...atus-store/src/test/java/sleeper/ingest/status/store/job/QueryIngestJobStatusByPeriodIT.java
Outdated
Show resolved
Hide resolved
...atus-store/src/test/java/sleeper/ingest/status/store/job/QueryIngestJobStatusByPeriodIT.java
Outdated
Show resolved
Hide resolved
...atus-store/src/test/java/sleeper/ingest/status/store/job/QueryIngestJobStatusByPeriodIT.java
Outdated
Show resolved
Hide resolved
patchwork01
approved these changes
Jan 5, 2023
kr565370
added
the
pr-base-for-stacking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #438
Hadoop also needs upgrading (along with AWS EMR & Spark), because Hadoop only supports Java 11 starting in version 3.3:
https://cwiki.apache.org/confluence/display/HADOOP/Hadoop+Java+Versions
There's a separate issue for that, although we could combine it back in: #472
Tested with system test, so it doesn't seem like there are any immediate issues with the old Hadoop version.